Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: arrow breaking in AILabel popover #17982

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

fix: arrow breaking in AILabel popover #17982

wants to merge 18 commits into from
+80 −15

Conversation

preetibansalui
Copy link
Contributor

@preetibansalui preetibansalui commented Nov 6, 2024 •
edited
Loading

Closes #17965

Arrow looks breaking in the AI explainability popover in case of small icons.

Changelog

added alignmentAxis in offset for popover.

Changed

passing a prop from AILabel to Toggletip component in case of 'XS', '2xs' or 'mini' icon.

Testing / Reviewing

  1. Go to Storybook > AILabel > Default
  2. hover on AI Label, the popover should not looks breaking.

@preetibansalui preetibansalui requested a review from a team as a code owner November 6, 2024 06:35
@netlify Netlify
Copy link

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 2d55a76
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/674489cb6e80e10008dcee66
😎 Deploy Preview https://deploy-preview-17982--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 6, 2024

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 1548b8f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/672b0e5174cffd0008b30df7
😎 Deploy Preview https://deploy-preview-17982--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 6, 2024

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1548b8f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/672b0e519b26c500080b6c27
😎 Deploy Preview https://deploy-preview-17982--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 2d55a76
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/674489cb24882b0008b2dc71
😎 Deploy Preview https://deploy-preview-17982--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 6, 2024

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6268c8a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/672b0f7145bd4900086786a6
😎 Deploy Preview https://deploy-preview-17982--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2d55a76
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/674489cbf7ed4e0008e55f05
😎 Deploy Preview https://deploy-preview-17982--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.87%. Comparing base (626289a) to head (2d55a76).

Files with missing lines Patch % Lines
packages/react/src/components/Popover/index.tsx 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #17982   +/-   ##
=======================================
  Coverage   82.87%   82.87%           
=======================================
  Files         404      404           
  Lines       14338    14344    +6     
  Branches     4591     4616   +25     
=======================================
+ Hits        11882    11887    +5     
+ Misses       2296     2295    -1     
- Partials      160      162    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

aagonzales
aagonzales reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caret looks like its 1px too low.
image

@preetibansalui preetibansalui requested a review from a team as a code owner November 13, 2024 09:31
@preetibansalui
Copy link
Contributor Author

The caret looks like its 1px too low. image

Thanks Anna for noticing this. It was caused by recent renaming of slug to ai-label, which is fixed now.

aagonzales
aagonzales approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

guidari
guidari approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

ariellalgilmore
ariellalgilmore approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidari guidari guidari approved these changes

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@aagonzales aagonzales aagonzales approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
status: one more review 👀 status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Arrow looks breaking in the AI explainability popover
4 participants
@preetibansalui @aagonzales @ariellalgilmore @guidari